Skip to content

Add missing readline/history.h include in NuParser #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing readline/history.h include in NuParser #103

wants to merge 1 commit into from

Conversation

alebcay
Copy link

@alebcay alebcay commented Jul 11, 2023 •
edited
Loading

When building on Ubuntu, we encounter the following errors:

objc/NuParser.m:1009:13: error: call to undeclared function 'read_history'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            read_history(history_file);
            ^
objc/NuParser.m:1030:13: error: call to undeclared function 'add_history'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            add_history (line);
            ^
objc/NuParser.m:1092:9: error: call to undeclared function 'write_history'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        write_history(history_file);
        ^
3 errors generated.
make: *** [Makefile:109: objc/NuParser.o] Error 1
make: *** Waiting for unfinished jobs....

As shown in this example, <readline/history.h> contains read_history, add_history, and write_history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alebcay